Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mayavi: update from Python 2 to Python 3 (and switch from wxPython to pyqt5) #85171

Merged
merged 4 commits into from Apr 21, 2020
Merged

python3Packages.mayavi: update from Python 2 to Python 3 (and switch from wxPython to pyqt5) #85171

merged 4 commits into from Apr 21, 2020

Conversation

bcdarwin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
python3Packages.envisage: update and disable for Python 2
2d8f346 
- next release will drop support for Python 2
@ofborg ofborg bot requested a review from knedlsepp April 13, 2020 18:14
@bcdarwin
Copy link
Member Author

bcdarwin commented Apr 13, 2020 •
edited

@GrahamcOfBorg build python37Packages.mayavi python38Packages.mayavi

@knedlsepp
Copy link
Member

Cool you could make this work. Will try that out ASAP.

@knedlsepp
Copy link
Member

knedlsepp commented Apr 13, 2020 •
edited

Built and tried and example visualization from: https://docs.enthought.com/mayavi/mayavi/auto/mlab_helper_functions.html#plot3d
Works fine (on current stable NixOS). 👍

knedlsepp
knedlsepp approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@knedlsepp knedlsepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this work with Python 3. Looks good to me.

@bcdarwin bcdarwin requested a review from FRidh April 14, 2020 16:44
@ofborg ofborg bot requested a review from knedlsepp April 14, 2020 16:51
@FRidh FRidh merged commit ef1679a into NixOS:master Apr 21, 2020
@bcdarwin bcdarwin deleted the python3-mayavi branch April 21, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@FRidh FRidh Awaiting requested review from FRidh

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @knedlsepp @FRidh