Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inkscape: 0.92.5 -> 1.0 #85169

Merged
merged 4 commits into from Jul 20, 2020
Merged

inkscape: 0.92.5 -> 1.0 #85169

merged 4 commits into from Jul 20, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 13, 2020

Motivation for this change

Update to Inkscape 1.0 final.

This PR also keeps Inkscape 0.92.5 as inkscape_0 package, because with 1.0 the CLI interface has been changed completely. Packages using Inkscape 0.x CLI interface were patched to use this instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 13, 2020

See also #50286

@prusnak
Copy link
Member Author

prusnak commented Apr 13, 2020

I had to add quite a lot of extra dependencies to satisfy the pkg-config. (These are marked explicitly via the comment). Not sure what is happening here. I thought this was because strictDeps = true, but removing this line did not help.

Maybe someone from the GTK team has an idea what's going on? @raskin @vcunat @lethalman @worldofpeace

Here's the list of the extra dependencies I had to add:

    pcre             # libpcre required by glib-2.0
    libpthreadstubs  # pthread-stubs required by xcb
    libXdmcp         # xdmcp required by xcb
    utillinuxMinimal # mount required by gio-2.0
    libselinux       # libselinux required by gio-2.0
    libsepol         # libsepol required by libselinx
    sqlite           # sqlite3 required by libsoup-2.4
    libpsl           # libpsl required by libsoup-2.4
    brotli           # libbrotlidec required by libsoup-2.4
    icu              # icu-i18n required by libvisio-0.1, libcdr-0.1
    libwpd           # libwpd-0.10 required by libwpg-0.3
    libxkbcommon     # xkbcommon required by gdk-3.0
    epoxy            # epoxy required by gdk-3.0
    dbus             # dbus-1 required by atk-bridge-2.0
    at-spi2-core     # atspi-2 required by atk-bridge-2.0
    at-spi2-atk      # atspi-2 required by atk-bridge-2.0
    libXtst          # xtst required by atspi-2

@prusnak
Copy link
Member Author

prusnak commented Apr 13, 2020

Hm, I just checked the inkscape in master (0.92.4) and I see the same pkg-config failures, so maybe these are expected and everything is OK?

@jtojnar
Copy link
Contributor

jtojnar commented Apr 13, 2020

For now, we should also bump to 0.92.5: #85184

@prusnak prusnak force-pushed the inkscape branch 2 times, most recently from 2970cae to afcbeb7 Compare April 14, 2020 08:59
@prusnak
Copy link
Member Author

prusnak commented Apr 14, 2020

I rebased the PR on top of the current master (which now has inkscape 0.92.5 with some cleanup merged in - thx @jtojnar).

I also removed the extra dependencies mentioned in the discussion above from the PR. I have them in a separate local commit in case these are still needed.

@prusnak
Copy link
Member Author

prusnak commented Apr 14, 2020

I addressed the comments from @jtojnar in 863becbf103

@prusnak
Copy link
Member Author

prusnak commented Apr 14, 2020

Darwin build timeouts after 1800 seconds in the CI

@jtojnar
Copy link
Contributor

jtojnar commented Apr 14, 2020

Looks good, thanks.

@jtojnar
Copy link
Contributor

jtojnar commented May 4, 2020

🎉 https://inkscape.org/news/2020/05/04/introducing-inkscape-10/

@minijackson
Copy link
Member

minijackson commented May 4, 2020

So I wanted to test out Inkscape 1.0 and mechanically did a nix-review on this PR ^^


Result of nix-review pr 85169 1

10 package failed to build:
  • adapta-gtk-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • arx-libertatis (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • emojione (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.gnome-documents (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • mojave-gtk-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • numix-solarized-gtk-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • plata-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • ripcord (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • twemoji-color-font (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • wpa_supplicant_gui (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
94 package were built:
  • aesop (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • arc-icon-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • arc-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • asciidoc-full (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • asciidoc-full-with-plugins (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • bibata-cursors (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • bibata-cursors-translucent (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • bibata-extra-cursors (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • bookworm (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • btrbk (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • capitaine-cursors (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • chrome-gnome-shell (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • clevis (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • dblatexFull (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • disorderfs (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • elementary-planner (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • faba-icon-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • faba-mono-icons (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • fim (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.gnome-control-center (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.gnome-session (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.gnome-shell (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.gnome-terminal (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnome3.pomodoro (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • gnomeExtensions.gsconnect (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • hashit (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • inkscape (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • luksmeta (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • mate.mate-utils (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • moka-icon-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • monitor (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • nasc (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • notejot (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • numix-cursor-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.appcenter (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-calculator (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-calendar (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-camera (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-code (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-feedback (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-files (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-greeter (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-gsettings-schemas (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-icon-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-music (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-onboarding (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-photos (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-screenshot-tool (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-session-settings (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-shortcut-overlay (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-terminal (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.elementary-videos (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.gala (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.sideload (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-a11y (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-about (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-applications (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-bluetooth (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-datetime (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-display (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-keyboard (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-mouse-touchpad (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-network (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-notifications (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-onlineaccounts (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-pantheon-shell (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-power (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-printers (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-security-privacy (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-sharing (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-plug-sound (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.switchboard-with-plugs (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-applications-menu (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-bluetooth (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-datetime (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-keyboard (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-network (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-nightlight (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-notifications (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-power (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-session (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-indicator-sound (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pantheon.wingpanel-with-indicators (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • pop-gtk-theme (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • quilter (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • regextester (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • snippetpixie (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • spice-up (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • tang (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • udiskie (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)
  • vocal (gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal)

From a quick glance it seems due to the removal of the --without-gui / -z CLI option.

Here are the logs of failed derivations, I hope it is useful:

https://gist.github.com/minijackson/46b4913eddd3cddecce09337179b2f62

ripcord's log is empty for some reason.

Otherwise, Inkscape seems to work great!

@spacekookie
Copy link
Member

I just ran inkscape from this PR and noticed a crash when trying to open the file-picker window (to open a file):

(org.inkscape.Inkscape:7308): GLib-GIO-ERROR **: 01:49:57.209: No GSettings schemas are installed on the system

@prusnak
Copy link
Member Author

prusnak commented May 10, 2020

This seems similar to #87457 - @jtojnar can you please confirm that moving glib to nativeBuildInputs is the correct way of fixing the issue?

@jtojnar
Copy link
Contributor

jtojnar commented May 10, 2020

Maybe try adding it there, it should still remain in buildInputs

@prusnak
Copy link
Member Author

prusnak commented May 10, 2020

@spacekookie can you try adding glib to nativeBuildInputs to see whether this helps?

@jtojnar
Copy link
Contributor

jtojnar commented May 15, 2020

Guix actually managed to unbundle the dependencies: https://lists.gnu.org/archive/html/guix-patches/2020-05/msg00365.html

@Pablo1107
Copy link
Contributor

Pablo1107 commented May 17, 2020

I imported this package from @prusnak fork tarball and it works perfect on NixOS 20.03.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 4, 2020

Rebased (fixing the conflicts) and added glib to nativeBuildInputs. It looks like it adds $GSETTINGS_SCHEMAS_PATH to the build environment at least.

Edit: also added gdk-pixbuf for setting GDK_PIXBUF_MODULE_FILE.

@raboof
Copy link
Member

raboof commented Jul 12, 2020

@GrahamcOfBorg build inkscape

@raboof
Copy link
Member

raboof commented Jul 12, 2020

@GrahamcOfBorg build gdl, gdl.passthru.tests, inkscape, inkscape.passthru.tests

@raboof
Copy link
Member

raboof commented Jul 12, 2020

@GrahamcOfBorg build gdl gdl.passthru.tests inkscape inkscape.passthru.tests

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-20-09/8035/7

Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

We can't update inkscape to 1.0 without keeping 0.x in tree,
because the CLI interface has been changed and lots of packages
use this interface for SVG conversion.
The Inkscape CLI interface has been changed with 1.x and packages
are not adjusted yet to this change. Let's use inkscape 0.x instead.
@prusnak
Copy link
Member Author

prusnak commented Jul 19, 2020

Rebased on top of the current master + changed the description of inkscape_0 package to "Legacy version of vector graphics editor".

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tested running it though.

@worldofpeace
Copy link
Contributor

I'm also fine with keeping around the old version of the package because of the cli changes.

@7c6f434c 7c6f434c merged commit 23c93a5 into NixOS:master Jul 20, 2020
@prusnak prusnak deleted the inkscape branch July 20, 2020 11:50
@aaronjanse
Copy link
Member

Ty all! I'm super excited to use this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet