New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inkscape: 0.92.5 -> 1.0 #85169
inkscape: 0.92.5 -> 1.0 #85169
Conversation
See also #50286 |
8f674f3
to
d4f7ee5
Compare
I had to add quite a lot of extra dependencies to satisfy the pkg-config. (These are marked explicitly via the comment). Not sure what is happening here. I thought this was because Maybe someone from the GTK team has an idea what's going on? @raskin @vcunat @lethalman @worldofpeace Here's the list of the extra dependencies I had to add:
|
Hm, I just checked the inkscape in master (0.92.4) and I see the same pkg-config failures, so maybe these are expected and everything is OK? |
For now, we should also bump to 0.92.5: #85184 |
2970cae
to
afcbeb7
Compare
I rebased the PR on top of the current master (which now has inkscape 0.92.5 with some cleanup merged in - thx @jtojnar). I also removed the extra dependencies mentioned in the discussion above from the PR. I have them in a separate local commit in case these are still needed. |
I addressed the comments from @jtojnar in 863becbf103 |
Darwin build timeouts after 1800 seconds in the CI |
Looks good, thanks. |
So I wanted to test out Inkscape 1.0 and mechanically did a Result of 10 package failed to build:
94 package were built:
From a quick glance it seems due to the removal of the Here are the logs of failed derivations, I hope it is useful: https://gist.github.com/minijackson/46b4913eddd3cddecce09337179b2f62 ripcord's log is empty for some reason. Otherwise, Inkscape seems to work great! |
I just ran inkscape from this PR and noticed a crash when trying to open the file-picker window (to open a file):
|
Maybe try adding it there, it should still remain in |
@spacekookie can you try adding |
Guix actually managed to unbundle the dependencies: https://lists.gnu.org/archive/html/guix-patches/2020-05/msg00365.html |
I imported this package from @prusnak fork tarball and it works perfect on NixOS 20.03. |
Rebased (fixing the conflicts) and added Edit: also added gdk-pixbuf for setting |
@GrahamcOfBorg build inkscape |
@GrahamcOfBorg build gdl, gdl.passthru.tests, inkscape, inkscape.passthru.tests |
@GrahamcOfBorg build gdl gdl.passthru.tests inkscape inkscape.passthru.tests |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-are-your-goals-for-20-09/8035/7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
We can't update inkscape to 1.0 without keeping 0.x in tree, because the CLI interface has been changed and lots of packages use this interface for SVG conversion.
The Inkscape CLI interface has been changed with 1.x and packages are not adjusted yet to this change. Let's use inkscape 0.x instead.
Rebased on top of the current master + changed the description of inkscape_0 package to "Legacy version of vector graphics editor". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, haven't tested running it though.
I'm also fine with keeping around the old version of the package because of the cli changes. |
Ty all! I'm super excited to use this! |
Motivation for this change
Update to Inkscape 1.0 final.
This PR also keeps Inkscape 0.92.5 as
inkscape_0
package, because with 1.0 the CLI interface has been changed completely. Packages using Inkscape 0.x CLI interface were patched to use this instead.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)