Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: unbundle pcre #85049

Merged
merged 1 commit into from Apr 12, 2020
Merged

libgit2: unbundle pcre #85049

merged 1 commit into from Apr 12, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Apr 12, 2020

Motivation for this change

libgit2 has bundled pcre (not pcre2) in
libgit2/libgit2#4935

Before this change configure printed "regex, using bundled PCRE",
after this change it prints "regex, using system PCRE".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@orivej
libgit2: unbundle pcre
569cd87 
libgit2 has bundled pcre (not pcre2) in
libgit2/libgit2#4935

Before this change configure printed "regex, using bundled PCRE",
after this change it prints "regex, using system PCRE".
@orivej-nixos orivej-nixos merged commit ecb3627 into NixOS:master Apr 12, 2020
@orivej orivej deleted the libgit2-pcre branch March 29, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @bhipple @orivej-nixos