Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worldofgoo: 1.41 -> 1.53 #85087

Merged
merged 2 commits into from Apr 12, 2020
Merged

worldofgoo: 1.41 -> 1.53 #85087

merged 2 commits into from Apr 12, 2020

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Apr 12, 2020

Motivation for this change

Latest version of the game (update from early 2019). The demo is no longer available for download so I removed support for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amaxine
maintainers: add maxeaubrey
82a9606
@amaxine
worldofgoo: 1.41 -> 1.53
1d440e1 
Removes demo (no longer available for download)
Adds i686 support, removing TODOs
@teto teto merged commit f08650c into NixOS:master Apr 12, 2020
@amaxine amaxine deleted the worldofgoo-1.53 branch April 13, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amaxine @teto