Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: macOS support before 10.7 #8078

Merged
merged 9 commits into from Apr 12, 2020
Merged

Conversation

michicc
Copy link
Member

@michicc michicc commented Apr 10, 2020

Updated and somewhat adapted from PR #8025, split a bit more into feature sets in case somebody has a need to revert a specific area. Target goal was 10.7 because that is the first version with any C++11 support, and almost nothing is gained by targeting 10.9.

Since the C++11 move, getting OpenTTD to compile and run for anything below 10.7 basically requires building a custom compiler and libc++. As such, this PR removes any special support for compiling with SDK versions before 10.7 and chucks most of the alternative, compatibility API support for video/sound/music/text.

The remaining implementations use whatever API level is still current, which is mostly something between 10.5 and 10.7. It should still be possible to compile OpenTTD targeting 10.7 with this PR.

I left some compatibility checks in that don't create any maintenance burdens or alternative code paths.

src/video/cocoa/cocoa_v.mm Outdated Show resolved Hide resolved
…0.4.

Since the C++11 move, getting OpenTTD to compile and run for anything
below 10.7 basically requires building a custom compiler and libc++.
Also, the QuickDraw subdriver crashes on more modern OSX version. While this
is fixable, keeping the driver around is probably pointless.
Since the move to C++11, building for pre 10.7 is not possible with the native
Apple tools. Also, due to bitrot, the file doesn't even compile anymore. While
this could be fixed, it shows that this subdriver is basically never used anymore.
@michicc michicc merged commit 4bfa3ff into OpenTTD:master Apr 12, 2020
@michicc michicc deleted the pr/osx_107_cleanup branch April 12, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants