Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: a5661135f29f
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 56f78c1ca444
Choose a head ref
  • 8 commits
  • 6 files changed
  • 1 contributor

Commits on Apr 13, 2020

  1. maintainer-list: Fix attribute names

    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    d3ac6de View commit details
    Browse the repository at this point in the history

  2. maintainer-list: Fix missing githubId's 

    All these IDs were carefully obtained with
- If possible, look at which commit introduced the maintainer and check
  with the GitHub API whether it was the person we think it should be.
  If yes, that's great
- If above doesn't work for any reason (which was the case for about
  half), then I went through the commit log and through GitHub PRs
  manually, to see who the person is

Sometimes this required trying to find a commit after the svn-era, but
before the committer stopped contributing. Sometimes when one person
adds two maintainers this required checking that they are known to each
other through bidirectional GitHub follows.

For tweber's github, see:
#82461 (comment)
    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    f9e94b9 View commit details
    Browse the repository at this point in the history

  3. lib/strings: Introduce escapeNixIdentifier

    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    f9eb3d1 View commit details
    Browse the repository at this point in the history

  4. lib/options: Use escapeNixIdentifier for showOption

    @infinisil
    infinisil committed Apr 13, 2020
    7
    Copy the full SHA
    124cccb View commit details
    Browse the repository at this point in the history

  5. lib/tests/modules.sh: Don't depend on $PWD

    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    0bc7f34 View commit details
    Browse the repository at this point in the history

  6. lib/tests/release.nix: Avoid importing nixpkgs into the store 

    Improves build time by about a factor of two on my system
    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    a90d8de View commit details
    Browse the repository at this point in the history

  7. lib/maintainer-list: Implement validity checks

    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    f579564 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #82461 from Infinisil/checked-maintainers 

    Checked maintainers
    @infinisil
    infinisil committed Apr 13, 2020
    Copy the full SHA
    56f78c1 View commit details
    Browse the repository at this point in the history