Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Enable CONFIG_NET_DROP_MONITOR by default #85119

Merged
merged 1 commit into from Apr 14, 2020
Merged

linux: Enable CONFIG_NET_DROP_MONITOR by default #85119

merged 1 commit into from Apr 14, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 13, 2020 •
edited

Motivation for this change

Needed for subscribing to dropped packets (e.g. via dropwatch).

On by default in:

Requested for:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • tested on 20.03
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 changed the base branch from master to staging April 13, 2020 02:30
@nh2
linux: Enable CONFIG_NET_DROP_MONITOR by default.
7081247 
Needed for subscribing to dropped packets (e.g. via `dropwatch`).
worldofpeace
worldofpeace approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

@worldofpeace
Copy link
Contributor

cc @NeQuissimus

@NeQuissimus
Copy link
Member

I assume this is going to work with all kernels we currently have?

@nh2
Copy link
Contributor Author

nh2 commented Apr 14, 2020

@NeQuissimus

I assume this is going to work with all kernels we currently have?

Yes:

According to https://cateee.net/lkddb/web-lkddb/NET_DROP_MONITOR.html, NET_DROP_MONITOR was introduced in Linux 2.6.30 under CONFIG_EXPERIMENTAL, and promoted to non-experimental in Linux 3.5. The oldest kernel we have is 4.*.

@teto teto merged commit f16ae2d into NixOS:staging Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @worldofpeace @NeQuissimus @teto