Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curRelease: guard against missing channel #37

Merged
merged 1 commit into from Apr 13, 2020
Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 13, 2020

No description provided.

@grahamc
Copy link
Member Author

grahamc commented Apr 13, 2020

on a new channel:

16:06 <gchristensen> Can't use an undefined value as a HASH reference at /nix/store/drqfyylks8ir4ya9sh4mzafpf30g5n1s-nixos-channel-scripts/bin/.mirror-nixos-branch-wrapped line 115.
16:07 <gchristensen> pretty sure bucketChannels is set, since it is  right afte ra guard
16:07 <gchristensen>    113  if ($bucketChannels) {
16:07 <gchristensen>    115      my $curRelease = $bucketChannels->get_key($channelName)->{'x-amz-website-redirect-location'} // "";
16:08 <gchristensen> I'm thinking my $curRelease = $bucketChannels->get_key($channelName) is returning nothing, is that considered an undefined variable though? :/

@grahamc
Copy link
Member Author

grahamc commented Apr 13, 2020

got a +1 from my local perlmonger.

@grahamc grahamc merged commit 7a68110 into master Apr 13, 2020
@grahamc grahamc deleted the fixup-new-chan branch April 13, 2020 01:40
@grahamc
Copy link
Member Author

grahamc commented Apr 13, 2020

01:45 -- Notice({^_^}): Channel nixpkgs-20.03-darwin advanced to NixOS/nixpkgs@708cb6b307b (from 5 hours ago, history: https://channels.nix.gsc.io/nixpkgs-20.03-darwin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant