Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: vim-which-key init #85121

Merged
merged 8 commits into from Apr 13, 2020
Merged

vimPlugins: vim-which-key init #85121

merged 8 commits into from Apr 13, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@garbas garbas requested a review from jonringer as a code owner April 13, 2020 02:33
@garbas garbas merged commit b7d362a into NixOS:master Apr 13, 2020
@garbas garbas deleted the vim-plugin-which-key branch April 13, 2020 02:35
@ofborg ofborg bot added the 6.topic: vim label Apr 13, 2020
matthiasbeyer
matthiasbeyer reviewed Nov 23, 2020
View reviewed changes
pkgs/misc/vim-plugins/generated.nix Outdated
sha256 = "197rp20hngrq7qdlii0ai4vb81dlilah0q1wlil8hv3qcf4az7qr";
};
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garbas can you please explain why a commit with message "aa" landed on nixpkgs and why it removes this vim plugin?

The commit message is, obviously, not self-explanatory!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthiasbeyer the PR got squashed, so the commit message never made it to nixpkgs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that github still shows the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer left review comments

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garbas @matthiasbeyer