Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: check clang version #85156

Merged
merged 1 commit into from Apr 13, 2020
Merged

boost: check clang version #85156

merged 1 commit into from Apr 13, 2020

Conversation

DieGoldeneEnte
Copy link
Contributor

Motivation for this change

boost <1.69 can't be compiled with clang >=8. This commit adds an assert to catch the error early on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DieGoldeneEnte
boost: check clang version
556b0e8 
boost <1.69 can't be compiled with clang >=8. This commit adds an assert
to catch the error early on.
@DieGoldeneEnte DieGoldeneEnte mentioned this pull request Apr 13, 2020
Closed
10 tasks
@Mic92 Mic92 merged commit 2d9888f into NixOS:master Apr 13, 2020
@thefloweringash thefloweringash mentioned this pull request Feb 14, 2022
Closed
19 tasks
thefloweringash added a commit to thefloweringash/nixpkgs that referenced this pull request Feb 14, 2022
@thefloweringash
boost: use clang 7 for versions older than 1.6.9
ad2191e 
Older versions of boost don't build with newer versions of clang
(see NixOS#85156), and the default clang version on x86_64-darwin is now
new enough that these older versions of boost no longer build.
@thefloweringash thefloweringash mentioned this pull request Feb 14, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DieGoldeneEnte @Mic92