Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advancecomp: version number correctly embedded in binaries #85129

Merged
merged 1 commit into from Apr 15, 2020
Merged

advancecomp: version number correctly embedded in binaries #85129

merged 1 commit into from Apr 15, 2020

Conversation

snicket2100
Copy link
Contributor

Motivation for this change

Without this fix, binaries report their version number as "vnone". With this fix they will report it currently as "v2.1". "vnone" for example stops image_optim from using advpng, it refuses
to use it not being able to tell what version number it has.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@snicket2100
advancecomp: version number correctly embedded in binaries
b1c14fb 
without this fix, binaries report their version number as "vnone"
which for example stops `image_optim` from using `advpng` (refuses
to use it not being able to tell what version number it has)
@snicket2100
Copy link
Contributor Author

this is the warning image_optim reports without this patch in place:

WARN: advpng none at /nix/store/9w01blga4w3ihr3jnkn0ym3x7zg8639b-advancecomp-2.1/bin/advpng (== none) is of unknown version

@ofborg ofborg bot requested a review from 7c6f434c April 13, 2020 08:30
@7c6f434c 7c6f434c merged commit 0f2c233 into NixOS:master Apr 15, 2020
@snicket2100 snicket2100 deleted the advancecomp-version-number-fix branch April 17, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snicket2100 @7c6f434c