Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin: 10.5.3 -> 10.5.4, add link to nixos test #85140

Merged
merged 2 commits into from Apr 14, 2020
Merged

jellyfin: 10.5.3 -> 10.5.4, add link to nixos test #85140

merged 2 commits into from Apr 14, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

I think this is how you link nixos tests ^^

cc @nyanloutre

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson minijackson changed the title 10.5.3 -> 10.5.4, add link to nixos test jellyfin: 10.5.3 -> 10.5.4, add link to nixos test Apr 13, 2020
@ofborg ofborg bot requested a review from nyanloutre April 13, 2020 10:57
@nyanloutre
Copy link
Member

I tested this on my system, it's working great

@worldofpeace
Copy link
Contributor

This is a hotfix release https://github.com/jellyfin/jellyfin/releases/tag/v10.5.4.
Could we also backport it to the stable channel?

@minijackson
Copy link
Member Author

Could we also backport it to the stable channel?

I'm all for it! Do I need to do something for the backport?

@worldofpeace
Copy link
Contributor

Could we also backport it to the stable channel?

I'm all for it! Do I need to do something for the backport?

See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

@worldofpeace worldofpeace merged commit 06159c6 into NixOS:master Apr 14, 2020
@minijackson minijackson deleted the jellyfin-10.5.4 branch April 15, 2020 08:41
@minijackson
Copy link
Member Author

So I just upgraded my server to use jellyfin 10.5.4, and it failed to start the service because of the "CinemaMode" plugin that I carried all the way from the migration from Emby. A simple solution is to move / remove the file /var/lib/jellyfin/Emby.Server.CinemaMode.dll. I don't know if we should do something packaging-wise, since these kinds of plugins come from Emby, and are not supported.

I could make a PR on the migration guide to hint people that they should remove these plugins.

@worldofpeace
Copy link
Contributor

So I just upgraded my server to use jellyfin 10.5.4, and it failed to start the service because of the "CinemaMode" plugin that I carried all the way from the migration from Emby. A simple solution is to move / remove the file /var/lib/jellyfin/Emby.Server.CinemaMode.dll. I don't know if we should do something packaging-wise, since these kinds of plugins come from Emby, and are not supported.

I could make a PR on the migration guide to hint people that they should remove these plugins.

I once upon a time had to workaround a permissions issue in emby a16c6d8. so handling things in that way can sometimes be easy.
Given that migration from emby isn't officially supported, mentioning this in that page would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @nyanloutre @worldofpeace