New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.janeStreet: 0.12 → 0.13 #85137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe explain in the commit message why async_ssl was removed?
@@ -12,6 +12,11 @@ buildDunePackage rec { | |||
sha256 = "114gq48cpj2mvycypa9lfyqqb26wa2gkdfwkcqhnx7m6sdwv9a38"; | |||
}; | |||
|
|||
patches = [(fetchpatch { | |||
url = https://github.com/pveber/bistro/commit/0931db43a146ad7829dff5120161a775f732a878.patch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote url
? Also, consider including a comment regarding this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
This is the legacy version for OCaml ≤ 4.02
ocamlPackages.bistro: fix for core-0.13 ocamlPackages.phylogenetics: 2020-01-05 → 2020-01-25
5c43636
to
8467524
Compare
|
||
minimumOCamlVersion = "4.08"; | ||
|
||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
janestreet now also has dune release tarballs, i. e. https://github.com/janestreet/${pname}/releases/download/v${version}/${pname}-v${version}.tbz
, maybe its worth it to use them via fetchurl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who will update all the hashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, probably not worth it...
Motivation for this change
Support for OCaml 4.10
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)