-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_3mux: init at 0.2.0 #85141
_3mux: init at 0.2.0 #85141
Conversation
Why did you name it |
Thank you @filalex77! I just tagged 3mux as I'd also love to be added as a maintainer of this derivation (nixpkgs user
Afaik, a Nix identifier cannot start with a numeral. The package |
@aaronjanse Thank you for checking in! I will update it to the tag (and drop the unstable suffix), and also add you as a maintainer. |
I also updated 3mux to use go modules before tagging |
@aaronjanse Great, thanks for letting me know! Yes, using |
fe36731
to
d196b90
Compare
Sorry, I just published some major bug fixes to tag Would you mind quickly updating this derivation to EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, built and tested on NixOS x86_64-linux 👍
I guess the darwin build should be skipped once it gets a build slot, since it is marked as broken. |
Motivation for this change
https://github.com/aaronjanse/3mux
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)