Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_3mux: init at 0.2.0 #85141

Merged
2 commits merged into from Apr 18, 2020
Merged

_3mux: init at 0.2.0 #85141

2 commits merged into from Apr 18, 2020

Conversation

Br1ght0ne
Copy link
Member

Motivation for this change

https://github.com/aaronjanse/3mux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

Why did you name it _3mux and not 3mux like in upstream?

@aaronjanse
Copy link
Member

Thank you @filalex77!

I just tagged 3mux as v0.1.0 so feel free to update the derivation to use that version. Now that it's tagged, is the -unstable suffix still recommended?

I'd also love to be added as a maintainer of this derivation (nixpkgs user aaronjanse).

Why did you name it _3mux and not 3mux like in upstream?

Afaik, a Nix identifier cannot start with a numeral. The package nixos._1password does the same thing.

@Br1ght0ne
Copy link
Member Author

@aaronjanse Thank you for checking in! I will update it to the tag (and drop the unstable suffix), and also add you as a maintainer.

@aaronjanse
Copy link
Member

I also updated 3mux to use go modules before tagging v0.1.0. Should this derivation be updated to use buildGoModule?

@Br1ght0ne
Copy link
Member Author

@aaronjanse Great, thanks for letting me know! Yes, using buildGoModule is much better, as we don't need to maintain separate deps.nix file. I'll do that :)

@Br1ght0ne Br1ght0ne changed the title _3mux-unstable: init at 2020-04-13 _3mux: init at 0.1.0 Apr 13, 2020
@ofborg ofborg bot requested review from aaronjanse and kalbasit April 13, 2020 22:06
@aaronjanse
Copy link
Member

aaronjanse commented Apr 14, 2020

Sorry, I just published some major bug fixes to tag v0.1.1. From now on, 3mux should be much more stable (I've created a dev branch!).

Would you mind quickly updating this derivation to v0.1.1? No dependencies have changed.

EDIT: v0.2.0

@Br1ght0ne Br1ght0ne changed the title _3mux: init at 0.1.0 _3mux: init at 0.2.0 Apr 18, 2020
Copy link
Contributor

@bqv bqv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested a review from aaronjanse April 18, 2020 15:50
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, built and tested on NixOS x86_64-linux 👍

@ghost
Copy link

ghost commented Apr 18, 2020

I guess the darwin build should be skipped once it gets a build slot, since it is marked as broken.

@ghost ghost merged commit f6be877 into NixOS:master Apr 18, 2020
@ghost
Copy link

ghost commented Apr 18, 2020

GutHub, you're drunk..
I pressed squash, got this:
screenshot
Reloaded the page and it was merged, but what the..:
screenshot2
So it created a merge commit and renamed it to the commit message I had entered, but did not use the commit description I had entered and did not squash.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants