Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] Yggdrasil backport #85058

Merged
merged 2 commits into from Apr 19, 2020
Merged

[19.09] Yggdrasil backport #85058

merged 2 commits into from Apr 19, 2020

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Apr 12, 2020

Motivation for this change

Allows hosts on the 19.09 release to join the Yggdrasil overlay. Yggdrasil has been working without issues in master since 19.06.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry ehmry requested a review from infinisil as a code owner April 12, 2020 09:07
@ehmry
maintainers: backport gazally
740cfe1
@ehmry
yggdrasil: backport at 0.3.10
2eb6231 
Backport of Yggdrasil, NixOS module, and tests.
@ehmry ehmry requested review from gazally and Lassulus April 12, 2020 09:23
@flokli
Copy link
Contributor

flokli commented Apr 12, 2020

Is this in master or release-20.03? If it's in master and 20.03 already, I'm wondering if we should just wait for 20.03 to be released…

@ehmry ehmry merged commit 9237a09 into NixOS:release-19.09 Apr 19, 2020
@ehmry ehmry deleted the yggdrasil-19.09 branch April 19, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@gazally gazally Awaiting requested review from gazally

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmry @flokli