Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chiaki: 1.0.3 -> 1.1.3 #85060

Merged
merged 1 commit into from Apr 12, 2020
Merged

chiaki: 1.0.3 -> 1.1.3 #85060

merged 1 commit into from Apr 12, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Apr 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from delroth April 12, 2020 09:19
delroth
delroth approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed still building and working.

@bhipple
Copy link
Contributor

bhipple commented Apr 12, 2020

Result of nixpkgs-review pr 85060 1

1 package built:
- chiaki

@bhipple bhipple merged commit 23cbc54 into NixOS:master Apr 12, 2020
@Moredread Moredread deleted the chiaki branch May 5, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @bhipple @delroth