Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak principia_make.sh cmake flags #2

Closed
wants to merge 34 commits into from

Conversation

ts826848
Copy link

CMAKE_LD_FLAGS isn't recognized by CMake:

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_LD_FLAGS

No replacement is needed since static libraries are created for
consumption by Principia and those use ar instead of ld.

"." is added to the command line to future-proof the command against
future CMake releases:

CMake Warning:
  No source or binary directory provided.  Both will be assumed to be the
  same as the current working directory, but note that this warning will
  become a fatal error in future CMake releases.

eggrobin and others added 4 commits April 10, 2020 15:27
CMAKE_LD_FLAGS isn't recognized by CMake:

    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_LD_FLAGS

No replacement is needed since static libraries are created for
consumption by Principia and those use ar instead of ld.

"." is added to the command line to future-proof the command against
future CMake releases:

    CMake Warning:
      No source or binary directory provided.  Both will be assumed to be the
      same as the current working directory, but note that this warning will
      become a fatal error in future CMake releases.
@pleroy pleroy force-pushed the master branch 2 times, most recently from 2accd87 to c2c317a Compare May 23, 2021 11:10
@eggrobin
Copy link
Member

eggrobin commented Apr 7, 2023

I did not notice this PR, but I think it is related to this discussion: https://discord.com/channels/319857228905447436/480397772248580098/698739181240713296.
Reading that, it is unclear whether we wanted to merge that in the first place, but now it won’t merge anyway.
Closing.

@eggrobin eggrobin closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants