Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libwacom: 1.1 -> 1.3 #85051

Merged
merged 2 commits into from
Apr 14, 2020
Merged

libwacom: 1.1 -> 1.3 #85051

merged 2 commits into from
Apr 14, 2020
+6 −5

Conversation

cgevans
Copy link
Contributor

@cgevans cgevans commented Apr 12, 2020 •
edited
Loading

Motivation for this change

Updating libwacom from 1.1 to 1.3, for updated tablet definitions. Added doxygen and cmake to get compilation to work.

I am opening this PR in advance of actually seeing if it breaks anything, because many pkgs depend on this. This also seems to have no maintainer set, and I'm a bit uncomfortable adding myself as a maintainer for such a core package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@cgevans cgevans changed the title libwacom: 1.1 -> 1.4 libwacom: 1.1 -> 1.3 Apr 12, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 12, 2020

With the number of rebuilds, this should go against staging, not master; mind rebasing and re-targeting the PR?

@cgevans cgevans changed the base branch from master to staging April 12, 2020 18:50
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 2.status: merge conflict This PR has merge conflicts with the target branch labels Apr 12, 2020
@jtojnar
Copy link
Member

jtojnar commented Apr 12, 2020

@worldofpeace should we include this into the scope of freedesktop team?

@jtojnar
Copy link
Member

jtojnar commented Apr 12, 2020

Changes look okay:

@worldofpeace
Copy link
Contributor

@worldofpeace should we include this into the scope of freedesktop team?

I believe any member of the freedesktop team should be very familiar/capable of overseeing libwacom. Like, I'd do the same for libinput at least. Though it does make me question ownership/maintainer-ship a bit deeper here.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 14, 2020
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 14, 2020
@ofborg ofborg bot requested review from jtojnar and worldofpeace April 14, 2020 13:15
@worldofpeace worldofpeace merged commit df012cc into NixOS:staging Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cgevans @bhipple @jtojnar @worldofpeace