Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] llvm 9 update #85151

Closed
wants to merge 15 commits into from
Closed

[WIP] llvm 9 update #85151

wants to merge 15 commits into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 13, 2020

Motivation for this change

Evaluation comparing regressions with master here
https://hydra.nixos.org/eval/1579054?compare=1575607#tabs-now-fail

TODO The darwin bootstrap-tools should be rebuilt after these changes and uploaded to tarballs.nixos.org.

/cc @NixOS/darwin-maintainers @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

LnL7 and others added 8 commits July 18, 2020 14:45
    make[1]: Entering directory '/private/tmp/nix-build-groff-1.22.4.drv-0/groff-1.22.4'
      CXX      src/devices/grodvi/dvi.o
      CXX      src/libs/libdriver/input.o
      CXX      src/libs/libdriver/printer.o
      AR       libdriver.a
      CXX      src/libs/libgroff/libgroff_a-assert.o
    In file included from src/libs/libgroff/assert.cpp:20:
    In file included from /nix/store/z25l6l358gcf0slg81rw8xxs3sjnghwc-libc++-9.0.0/include/c++/v1/stdlib.h:100:
    ./lib/math.h:38:3: error: "Please include config.h first."
     #error "Please include config.h first."
      ^
    ./lib/math.h:40:1: error: unknown type name '_GL_INLINE_HEADER_BEGIN'
    _GL_INLINE_HEADER_BEGIN
coreclr needs to be compiled with clang 7, because of the internal
assembler.
I duplicated the change from 054dc14
here to prevent duplicating the commit.
irods needs llvmPackages_7, because it uses boost160.
@LnL7 LnL7 added this to Stdenv in Darwin Oct 24, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-is-darwin-llvm-so-old/10822/2

toonn added a commit to toonn/nixpkgs that referenced this pull request May 23, 2021
Credits to @LnL7, this is based on commit
ae68f1c from PR NixOS#85151.
toonn added a commit to toonn/nixpkgs that referenced this pull request Jun 5, 2021
Credits to @LnL7, this is based on commit
ae68f1c from PR NixOS#85151.
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
sternenseemann pushed a commit to sternenseemann/nixpkgs that referenced this pull request Jul 24, 2021
Credits to @LnL7, this is based on commit
ae68f1c from PR NixOS#85151.
@Mindavi
Copy link
Contributor

Mindavi commented Nov 27, 2021

Is this still relevant?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 27, 2021
@veprbl veprbl removed this from Stdenv in Darwin Mar 5, 2022
@Atemu
Copy link
Member

Atemu commented Mar 30, 2022

This has been superseded by #126411 and #142593

@Atemu Atemu closed this Mar 30, 2022
Staging automation moved this from WIP to Done Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants