bookworm: fixing the executable name #85150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the executable name used to be 'com.github.babluboy.bookworm', this commit changes it to just 'bookworm'.
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Mic92
reviewed
Apr 13, 2020
|
|
||
| # this changes the executable name | ||
| # from 'com.github.babluboy.bookworm' to 'bookworm' | ||
| sed -i "s/ meson.project_name(),/ 'bookworm',/g" meson.build; |
There was a problem hiding this comment.
I would rather make a symlink after installation. Other packages might depend on this executable to be available.
|
Apps curated in the elementary OS ecosystem have their binary's RDDN for a reason, no namespace collisions. These are graphical applications, so launching them via executable manually with a convenient name isn't that important. I'd much rather communicate to the projects that the meson build system should create a convenience symlink. |
|
Because of that I'm inclined to close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
the executable name used to be
com.github.babluboy.bookworm. this commit changes it to justbookworm, seems cleaner this way.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)