llvmPackages: 7.1.0 -> 9.0.1 #85143
llvmPackages: 7.1.0 -> 9.0.1 #85143
Conversation
This way clang, llvm and lldb all use the same version.
boost <1.69 can't be compiled with clang >=8. This commit adds an assert to catch the error early on.
There was a problem hiding this comment.
This needs more work than just updating, since this is a major change for the darwin ecosystem (similar to bumping gcc for linux).
That said, I have already been preparing changes for the update, these are the initial changes I've made so far https://github.com/LnL7/nixpkgs/commits/llvm-9-update. Last week I also started an evaluation for this to get an overview of the regressions https://hydra.nixos.org/eval/1579054?compare=1575607#tabs-unfinished. The builds have also been delayed for a bit by the 20.03 release. Once that's finished we can asses what should be fixed along with the update before it can be merged.
It's probably a bit early at this point but If you'd like to help in with the effort most of these failures can most likely be reproduced on linux, like some of the fixes you've made already.
|
@LnL7 I knew this is a big change for darwin, although I don't know the darwin specific packages. I intended to use this PR to pool the effort. I think it would be more useful if I close this PR and you open a [WIP] PR from your branch? |
|
@DieGoldeneEnte See #85151. |
Motivation for this change
As pointed out in #84096 llvmPackages still points to llvm 7. This commit changes llvmPackages to llvm 9. I chose not to use llvm 10, since it was just released.
Since boost16x is boost 1.69 using clang >7 should work in most cases (<1.69 needs clang <=7).
This still needs to be tested on darwin! If you can tell me how to test without darwin machine, I'll compile/fix myself.
On linux all packages building before these changes are still building afterwards.
Things done
coreclrnow uses clang found in passed llvmPackages, instead of separate argument to ensure all llvm-tools use the same versionboosthas extra assert to catch compiling boost <1.69 with clang >=8 early on. This combination is not possible, because clang removed a feature.irodsandcoreclrto llvm 7, since both can not be compiled with newer clang (irods needs boost <1.69 and coreclr has problems with clangs internal assembler after version 8)sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)