Comment by programmerjake
Thursday Jul 11, 2019 at 04:14 GMT

I ran all the unittests on pypy3 locally, none of them failed. This makes me think the issue is caching, interference between pypy3 and cpython, or the fact that I'm using pypy3.6-v7.1.0 instead of v7.1.1.

Comment by programmerjake
Thursday Jul 11, 2019 at 04:23 GMT

pypy3.6-v7.1.1 works as well

Comment by programmerjake
Thursday Jul 11, 2019 at 06:13 GMT

I got it to fail locally by running in a pypy3 virtualenv, maybe symbiyosys's scripts don't work with a virtualenv

Comment by programmerjake
Thursday Jul 11, 2019 at 06:26 GMT

travis-ci passed when not using a virtualenv: https://travis-ci.com/programmerjake/nmigen/builds/118721712

Comment by programmerjake
Thursday Jul 11, 2019 at 07:40 GMT

turns out travis-ci passing was a false positive, it didn't actually use pypy3

Comment by programmerjake
Thursday Jul 11, 2019 at 07:58 GMT

I think the reason the unittests pass locally is because I've been running them by calling pypy3 explicitly, so SymbiYosys still uses cpython, since python3 has not been symlinked to pypy3.

To fix this bug, I think we'll probably have to add a workaround to SymbiYosys. Even once pypy fixes the issue, not everyone will have the fixed version of pypy or want to build their own.

Comment by whitequark
Thursday Jul 11, 2019 at 09:38 GMT

Sure. Feel free to add a workaround and cc me on the PR.

Comment by programmerjake
Monday Jul 22, 2019 at 21:13 GMT

pypy commited fix for internal error: https://bitbucket.org/pypy/pypy/commits/487165124904
didn't test yet

Comment by whitequark
Tuesday Sep 10, 2019 at 04:42 GMT

@programmerjake Ping--could you revisit this please?

Comment by programmerjake
Wednesday Sep 11, 2019 at 00:07 GMT

last I had checked, it appeared as though symbiyosys would need extensive changes to work around that pypy bug since the bug appears to affect all built-in nonblocking read operations. either symbiyosys would need to be changed to use blocking reads (maybe via multithreading) or there would need to be a way to bypass pypy's broken read operation -- both of which sounds quite invasive.

I could be wrong, however.

I think the best way to proceed may be to just disable symbiyosys tests when the buggy versions of pypy are detected.

Comment by whitequark
Wednesday Sep 11, 2019 at 09:30 GMT

I think the best way to proceed may be to just disable symbiyosys tests when the buggy versions of pypy are detected.

Sounds fine to me.