Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: 0.13.69 → 0.13.71 #85147

Merged
merged 1 commit into from Jun 18, 2020
Merged

zziplib: 0.13.69 → 0.13.71 #85147

merged 1 commit into from Jun 18, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 13, 2020 •
edited

Motivation for this change

Another step in getting rid of Python 2 (continued from #76488)

https://github.com/gdraheim/zziplib/releases/tag/v0.13.70
https://github.com/gdraheim/zziplib/releases/tag/v0.13.71

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Apr 13, 2020
Merged
@jtojnar jtojnar force-pushed the zziplib-0.13.70 branch 2 times, most recently from cdd727e to 31d2369 Compare April 17, 2020 20:01
@jtojnar jtojnar marked this pull request as ready for review April 17, 2020 20:02
@jtojnar jtojnar force-pushed the zziplib-0.13.70 branch 2 times, most recently from 2728b87 to a72cbf4 Compare April 18, 2020 17:13
@jtojnar jtojnar marked this pull request as draft June 1, 2020 05:19
@jtojnar jtojnar marked this pull request as ready for review June 18, 2020 10:17
@jtojnar jtojnar mentioned this pull request Jun 18, 2020
Merged
17 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 18, 2020

Tests were not working before and I would rather get rid of Python 2 sooner.

@jtojnar jtojnar merged commit c334340 into NixOS:master Jun 18, 2020
@jtojnar jtojnar deleted the zziplib-0.13.70 branch June 18, 2020 10:21
@jtojnar jtojnar changed the title zziplib: 0.13.69 → 0.13.70 zziplib: 0.13.69 → 0.13.71 Jun 18, 2020
@jtojnar jtojnar added this to Done in Python 2 deprecation Jun 18, 2020
@veprbl veprbl mentioned this pull request Jun 21, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtojnar