syslinux: add uefi support #85094
Merged
syslinux: add uefi support #85094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
The uefi support bit is great, thanks! I'd be very hesitant to support merging an out of band patch for something as integral as syslinux unless "blessed" by other distributions. |
|
Understandable. I dropped that commit, so now this only adds UEFI support, as it works on upstream syslinux. This means you can boot into syslinux from UEFI and start a Linux kernel with it, but cannot execute any other UEFI binaries (like an EFI Shell) from it. |
peterhoeg
reviewed
May 1, 2020
peterhoeg
reviewed
May 1, 2020
peterhoeg
reviewed
May 2, 2020
|
Should I maybe put these changes in a separate commit?
We normally do these minor cleanups when the package is being touched anyway.
|
|
Thanks for all your hard work @ajs124 |
jtojnar
reviewed
May 5, 2020
| url = mkURL "477e56d2" "0005-gnu-efi-version-compatibility.patch"; | ||
| sha256 = "041568b4abb79wynyps1n04lg4fr26rc3sbjncz99pp0mbz0ajlm"; | ||
| (fetchpatch { | ||
| url = "https://git.archlinux.org/svntogit/packages.git/plain/trunk/0005-gnu-efi-version-compatibility.patch?h=packages/syslinux"; |
There was a problem hiding this comment.
This is not a static URL, you need to pin it to Arch git commit.
jtojnar
reviewed
May 5, 2020
| @@ -48,6 +50,10 @@ stdenv.mkDerivation { | |||
| # fix tests | |||
| substituteInPlace tests/unittest/include/unittest/unittest.h \ | |||
| --replace /usr/include/ "" | |||
|
|
|||
| # Hack to get `gcc -m32' to work without having 32-bit Glibc headers. | |||
| mkdir gnu-efi/inc/ia32/gnu | |||
There was a problem hiding this comment.
Is it possible to use gnu-efi from the nixpkgs package instead of a submodule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #41403
The main changes are fetching submodules, using a patch with the same name, but a wider scope, from Arch Linux instead of Debian, dropping some make flags that break the build (yeah…) and a stubs-32.h hack I stole from... somewhere. Xen maybe?
The second commit adds an unofficial and not particularly polished patchset that adds support for EFI binary "chainloading". This successfully executes an UEFI Shell, but fails to run some other things like rEFInd.
It's a separate commit because, while I'd like to see the general UEFI support merged, I'm definitely willing to drop this patcheset, if that's what the maintainers/community prefers.
cc @samueldr @peterhoeg
Things done
Tested booting on UEFI and BIOS on real hardware and in qemu.