Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 15f8446bbac9
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2da6401bc241
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 13, 2020

  1. pythonPackages.ofxtools: unbreak 

    - Remove `sqlalchemy` from `buildInputs`. This dependency was removed in
  [0.7.0]. Per the project's readme, `ofxtools` only depends on the
  standard library.

- Disable for Python versions older than 3.7, the minimum Python version
  supported by `ofxtools` starting with the [0.8.17] release.

- Fix the `checkPhase` by fetching from GitHub instead of PyPI to get a
  distribution that includes tests, overriding the home directory to
  allow tests that depend on it being writeable, and switching to
  `nosetests` to match the upstream project's test setup.

[0.7.0]: csingley/ofxtools@8a79578
[0.8.17]: csingley/ofxtools@ddeda98
    @jonafato
    jonafato authored and Jon committed Apr 13, 2020
    Copy the full SHA
    2da6401 View commit details
Showing with 15 additions and 10 deletions.
  1. +15 −10 pkgs/development/python-modules/ofxtools/default.nix
25 changes: 15 additions & 10 deletions pkgs/development/python-modules/ofxtools/default.nix
View file
Original file line number Diff line number Diff line change
@@ -1,30 +1,35 @@
{ stdenv
, buildPythonPackage
, fetchPypi
, fetchFromGitHub
, nose
, python
, sqlalchemy
, pythonOlder
}:

buildPythonPackage rec {
pname = "ofxtools";
version = "0.8.20";

src = fetchPypi {
inherit pname version;
sha256 = "87245679911c0c12429a476fd269611512d3e4b44cb8871159bb76ba70f8a46f";
disabled = pythonOlder "3.7";

# PyPI distribution does not include tests
src = fetchFromGitHub {
owner = "csingley";
repo = pname;
rev = version;
sha256 = "1s3fhhmj1acnmqglh39003db0bi451m4hcrkcpyrkqf5m32lslz8";
};

checkInputs = [ nose ];
# override $HOME directory:
# error: [Errno 13] Permission denied: '/homeless-shelter'
checkPhase = ''
${python.interpreter} -m unittest discover -s ofxtools
HOME=$TMPDIR nosetests tests/*.py
'';

buildInputs = [ sqlalchemy ];

meta = with stdenv.lib; {
homepage = "https://github.com/csingley/ofxtools";
description = "Library for working with Open Financial Exchange (OFX) formatted data used by financial institutions";
license = licenses.mit;
broken = true;
};

}