Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sacd: init at 19.7.16.37 #82692

Merged
merged 1 commit into from Mar 27, 2020
Merged

sacd: init at 19.7.16.37 #82692

merged 1 commit into from Mar 27, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Mar 15, 2020 •
edited

Motivation for this change

https://github.com/Sound-Linux-More/sacd was missing - a very important and useful yet not well known software for converting SACD (super audio compact disk) ISO files to wav.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 27, 2020

@GrahamcOfBorg build sacd

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 27, 2020

The build is failing on aarch64 and darwin. If these platforms are not supported or your can't maintain them please restrict the build to x86_64 linux.

@doronbehar
Copy link
Contributor Author

Thanks for catching that @rnhmjoj . Fixed.

rnhmjoj
rnhmjoj approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now. Thank you.

@rnhmjoj rnhmjoj merged commit 4a3f9ac into NixOS:master Mar 27, 2020
@doronbehar doronbehar deleted the package-sacd branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @rnhmjoj