dmd: 2.085.1 -> 2.091.1 #82694

lionello · 2020-03-15T22:45:06Z

Motivation for this change

Current dmd in Nixpkgs uses ldc 0.17.6 to bootstrap ldc 1.x which will finally bootstrap dmd. This was done since the official dmd binaries where not redistributable.
This changed and as of 2.075.0 dmd binaries (and sources) are all using the Boost license. This simplifies bootstrapping so we can use the v-1 binaries to build the latest dmd sources.

Things done

Using official 2.090.1 binary for bootstrapping 2.091.1

lionello · 2020-03-15T22:47:29Z

@adisbladis @ThomasMader Please have a look.

lionello · 2020-03-15T22:53:50Z

WIP. got a test failure here..

kinke · 2020-03-15T23:09:17Z

Wrt. LDC, I strongly suggest you look for alternatives to bootstrapping with v0.17: ldc-developers/ldc#3354

lionello · 2020-03-20T14:23:57Z

This is OK now @adisbladis

adisbladis · 2020-03-20T23:33:18Z

@GrahamcOfBorg build ldc dmd

lionello · 2020-04-18T03:12:27Z

~~@adisbladis Do you want to ask grahamcofborg to build the new toplevel dmdBootstrap as well?~~

ThomasMader · 2020-04-18T05:02:51Z

Great work @lionello, thanks.

Would you mind changing the bootstrap of ldc?
The bootstrap version 0.17.x shouldn't be used anymore but instead a solution as you did for bootstrapping dmd should be preferred.
I wanted to do it for a long time but now that you already achieved it with dmd it should be straight forward with ldc I guess.

lionello · 2020-04-18T06:37:58Z

@ThomasMader Good idea.

ThomasMader · 2020-04-18T09:15:53Z

@lionello Why do you want to build dmdBootstrap explicitly? Isn't it enough that it builds with normal dmd?

lionello · 2020-04-18T10:03:12Z

@lionello Why do you want to build dmdBootstrap explicitly? Isn't it enough that it builds with normal dmd?

Doh. :) Good point.

lionello · 2020-04-18T10:15:46Z

Would you mind changing the bootstrap of ldc?
The bootstrap version 0.17.x shouldn't be used anymore but instead a solution as you did for bootstrapping dmd should be preferred.
I wanted to do it for a long time but now that you already achieved it with dmd it should be straight forward with ldc I guess.

@ThomasMader Please have a look here: #85488

ThomasMader

Thanks a lot for this!

pkgs/development/compilers/dmd/bootstrap.nix

pkgs/top-level/all-packages.nix

ThomasMader · 2020-04-21T07:04:04Z

I tried it and it works for me.

At least on Darwin. Haven't tried it on Linux/NixOS though.

Geod24 · 2020-04-21T07:14:27Z

pkgs/development/compilers/dmd/default.nix

@@ -103,7 +108,7 @@ stdenv.mkDerivation rec {

  checkPhase = ''
    cd dmd
-    make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 CC=$CXX DMD=${pathToDmd} BUILD=release SHELL=$SHELL
+    make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 DMD=${pathToDmd} BUILD=release SHELL=$SHELL


Suggested change

make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 DMD=${pathToDmd} BUILD=release SHELL=$SHELL

make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 HOST_CXX=${CXX} DMD=${pathToDmd} BUILD=release SHELL=$SHELL

IIUC

Geod24 · 2020-04-21T14:24:47Z

BTW 2.091.1 is out now

worldofpeace · 2020-04-22T12:15:46Z

To avoid breakage on master I reverted the merge of the ldc update #85768. Can we revert that revert here? Ref #85488 (comment)

lionello · 2020-04-25T03:09:26Z

/private/tmp/d/dmd/test/dshell/test6952.d(32): Error: none of the overloads of `run` are callable using argument types `(string, File, File, string[string])`, candidates are:

:(

Geod24 · 2020-04-25T04:33:15Z

Try to add dlang/dmd@4157298 before the patch.

PetarKirov · 2020-04-26T13:20:42Z

Hey @lionello @ThomasMader @worldofpeace, what's left to be done?

worldofpeace · 2020-04-26T17:52:29Z

@GrahamcOfBorg build dmd

lionello · 2020-04-26T22:40:16Z

Latest patch added a path reference to bash that had to be replaced. Just pushed.

lionello · 2020-04-26T22:41:16Z

@GrahamcOfBorg build dmd

lionello · 2020-04-26T22:48:24Z

To avoid breakage on master I reverted the merge of the ldc update #85768. Can we revert that revert here? Ref #85488 (comment)

Done.

lionello · 2020-04-26T23:07:37Z

@worldofpeace Passed.

pkgs/top-level/aliases.nix

lionello · 2020-04-28T11:50:58Z

@worldofpeace I made the change you requested. Can you have a (final?) look?

worldofpeace · 2020-04-28T14:56:15Z

@lionello All good, can you squash that last commit into 54701d2 ?

Apply patch dlang/dmd#11053

This reverts commit 31d630c.

lionello · 2020-04-29T12:49:27Z

@worldofpeace Done!

lionello · 2020-04-29T22:01:30Z

Wooohoo! Thanks all!

lionello force-pushed the dmd-bootstrap branch from d4503d1 to e19096d Compare March 15, 2020 22:48

lionello mentioned this pull request Mar 15, 2020

Fix issue 20019: Symbol not found: _dyld_enumerate_tlv_storage on macOS 10.15 ldc-developers/druntime#172

Merged

veprbl changed the title ~~dmd: 2.085.1 -> 2.091.0~~ [WIP] dmd: 2.085.1 -> 2.091.0 Mar 15, 2020

adisbladis force-pushed the dmd-bootstrap branch 2 times, most recently from 82fd1f1 to 41d23a1 Compare March 16, 2020 01:13

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 16, 2020

adisbladis force-pushed the dmd-bootstrap branch from 41d23a1 to 3a87d97 Compare March 16, 2020 01:24

lionello force-pushed the dmd-bootstrap branch from 3a87d97 to 449b502 Compare April 18, 2020 02:50

lionello changed the title ~~[WIP] dmd: 2.085.1 -> 2.091.0~~ dmd: 2.085.1 -> 2.091.0 Apr 18, 2020

lionello force-pushed the dmd-bootstrap branch from 449b502 to 0f2f692 Compare April 18, 2020 03:03

ofborg bot added the 11.by: package-maintainer label Apr 18, 2020

lionello force-pushed the dmd-bootstrap branch from 0f2f692 to d9e2362 Compare April 18, 2020 08:58

lionello mentioned this pull request Apr 18, 2020

ldc: 1.17.0 -> 1.20.1 #85488

Merged

10 tasks

lionello changed the title ~~dmd: 2.085.1 -> 2.091.0~~ [WIP] dmd: 2.085.1 -> 2.091.0 Apr 18, 2020

lionello mentioned this pull request Apr 18, 2020

dmd: 2.085.1 -> 2.090.0 #78995

Closed

10 tasks

lionello force-pushed the dmd-bootstrap branch from d9e2362 to cc6a099 Compare April 18, 2020 12:49

ThomasMader approved these changes Apr 18, 2020

View reviewed changes

pkgs/development/compilers/dmd/bootstrap.nix Show resolved Hide resolved

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

Geod24 reviewed Apr 21, 2020

View reviewed changes

lionello force-pushed the dmd-bootstrap branch from 4b367a2 to ccba5ea Compare April 24, 2020 12:48

lionello changed the title ~~dmd: 2.085.1 -> 2.091.0~~ dmd: 2.085.1 -> 2.091.1 Apr 24, 2020

lionello force-pushed the dmd-bootstrap branch from ccba5ea to 7d36ae9 Compare April 25, 2020 12:35

lionello force-pushed the dmd-bootstrap branch from d10942f to 54701d2 Compare April 26, 2020 22:47

ofborg bot added the 8.has: clean-up label Apr 26, 2020

worldofpeace reviewed Apr 27, 2020

View reviewed changes

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved

lionello added 4 commits April 29, 2020 07:31

dmd: 2.085.1 -> 2.091.1

6c9beaa

Apply patch dlang/dmd#11053

Update patch dlang/dmd#11053

6e7a36b

Patch bash in test6952.d

e0777cb

ldc: 1.17.0 -> 1.20.1

386da32

This reverts commit 31d630c.

lionello force-pushed the dmd-bootstrap branch from 71fe24e to 386da32 Compare April 28, 2020 23:32

worldofpeace merged commit 3b00e78 into NixOS:master Apr 29, 2020

lionello deleted the dmd-bootstrap branch April 30, 2020 00:18

lionello mentioned this pull request Dec 14, 2021

ldc: add aarch64-linux #150744

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dmd: 2.085.1 -> 2.091.1 #82694

dmd: 2.085.1 -> 2.091.1 #82694

lionello commented Mar 15, 2020 •

edited

Loading

lionello commented Mar 15, 2020

lionello commented Mar 15, 2020

kinke commented Mar 15, 2020

lionello commented Mar 20, 2020

adisbladis commented Mar 20, 2020

lionello commented Apr 18, 2020 •

edited

Loading

ThomasMader commented Apr 18, 2020

lionello commented Apr 18, 2020

ThomasMader commented Apr 18, 2020

lionello commented Apr 18, 2020

lionello commented Apr 18, 2020 •

edited

Loading

ThomasMader left a comment

ThomasMader commented Apr 21, 2020 •

edited

Loading

Geod24 Apr 21, 2020

Geod24 commented Apr 21, 2020

worldofpeace commented Apr 22, 2020 •

edited

Loading

lionello commented Apr 25, 2020

Geod24 commented Apr 25, 2020

PetarKirov commented Apr 26, 2020

worldofpeace commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 28, 2020

worldofpeace commented Apr 28, 2020

lionello commented Apr 29, 2020

lionello commented Apr 29, 2020

	make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 DMD=${pathToDmd} BUILD=release SHELL=$SHELL
	make -j$NIX_BUILD_CORES -C test -f Makefile PIC=1 HOST_CXX=${CXX} DMD=${pathToDmd} BUILD=release SHELL=$SHELL

dmd: 2.085.1 -> 2.091.1 #82694

dmd: 2.085.1 -> 2.091.1 #82694

Conversation

lionello commented Mar 15, 2020 • edited Loading

Motivation for this change

Things done

lionello commented Mar 15, 2020

lionello commented Mar 15, 2020

kinke commented Mar 15, 2020

lionello commented Mar 20, 2020

adisbladis commented Mar 20, 2020

lionello commented Apr 18, 2020 • edited Loading

ThomasMader commented Apr 18, 2020

lionello commented Apr 18, 2020

ThomasMader commented Apr 18, 2020

lionello commented Apr 18, 2020

lionello commented Apr 18, 2020 • edited Loading

ThomasMader left a comment

Choose a reason for hiding this comment

ThomasMader commented Apr 21, 2020 • edited Loading

Geod24 Apr 21, 2020

Choose a reason for hiding this comment

Geod24 commented Apr 21, 2020

worldofpeace commented Apr 22, 2020 • edited Loading

lionello commented Apr 25, 2020

Geod24 commented Apr 25, 2020

PetarKirov commented Apr 26, 2020

worldofpeace commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 26, 2020

lionello commented Apr 28, 2020

worldofpeace commented Apr 28, 2020

lionello commented Apr 29, 2020

lionello commented Apr 29, 2020

lionello commented Mar 15, 2020 •

edited

Loading

lionello commented Apr 18, 2020 •

edited

Loading

lionello commented Apr 18, 2020 •

edited

Loading

ThomasMader commented Apr 21, 2020 •

edited

Loading

worldofpeace commented Apr 22, 2020 •

edited

Loading