Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: 6.4.6 -> 6.6.4 #82690

Closed
wants to merge 1 commit into from
Closed

rocksdb: 6.4.6 -> 6.6.4 #82690

wants to merge 1 commit into from

Conversation

basvandijk
Copy link
Member

Motivation for this change

https://github.com/facebook/rocksdb/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build rocksdb

@nh2
Copy link
Contributor

nh2 commented Mar 18, 2020

nix-review output:

1 package marked as broken and skipped:
bareos

1 package failed to build:
sortmerna

11 package built:
blockbook ceph ceph-client haskellPackages.corenlp-parser haskellPackages.rocksdb-haskell haskellPackages.rocksdb-query libceph rocksdb rocksdb_lite sambaFull zeek

sortmerna fails with:

-- Configuring done
CMake Error at src/sortmerna/CMakeLists.txt:78 (add_executable):
  Target "sortmerna" links to target "snappy::snappy" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Error at src/sortmerna/CMakeLists.txt:78 (add_executable):
  Target "sortmerna" links to target "lz4::lz4" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?


CMake Error at src/sortmerna/CMakeLists.txt:78 (add_executable):
  Target "sortmerna" links to target "zstd::zstd" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Error at src/sortmerna/CMakeLists.txt:54 (add_library):
  Target "smr_objs" links to target "snappy::snappy" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Error at src/sortmerna/CMakeLists.txt:54 (add_library):
  Target "smr_objs" links to target "lz4::lz4" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?


CMake Error at src/sortmerna/CMakeLists.txt:54 (add_library):
  Target "smr_objs" links to target "zstd::zstd" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?

That is probably not related to rocksdb.

@nh2
Copy link
Contributor

nh2 commented Mar 18, 2020

That is probably not related to rocksdb.

Actually, looks like it is: Cherry-picking this PR on top of current staging commit 16516ce (where sortmerna builds) makes the build break!

@nh2
Copy link
Contributor

nh2 commented Mar 18, 2020

cc @luispedro as sortmerna maintainer

@luispedro
Copy link
Contributor

I wonder if these dependencies (zstd, snappy,...) should not move to propagatedBuildInputs?

@prusnak
Copy link
Member

prusnak commented Jul 17, 2020

Superseded by #93363

@prusnak prusnak closed this Jul 17, 2020
@prusnak prusnak mentioned this pull request Jul 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magenbluten magenbluten Awaiting requested review from magenbluten

@adevress adevress Awaiting requested review from adevress

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basvandijk @nh2 @luispedro @prusnak