Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

development/libraries/libdap: fix hash #82521

Merged
merged 1 commit into from Mar 29, 2020
Merged

development/libraries/libdap: fix hash #82521

merged 1 commit into from Mar 29, 2020

Conversation

Xe
Copy link
Contributor

@Xe Xe commented Mar 14, 2020 •
edited

Motivation for this change

Fixes hash for #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bzizou March 14, 2020 01:16
@alyssais
Copy link
Member

Do we know why the hash changed?

@alyssais
Copy link
Member

alyssais commented Mar 14, 2020 •
edited 

--- a/README
+++ b/README
@@ -1,9 +1,11 @@
Please find the libdap4 API documentation here: https://opendap.github.io/libdap4/html/

+[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.3641778.svg)](https://doi.org/10.5281/zenodo.3641778)
+
 Updated for version 3.20.5
 
 Memory leaks. Minor bug fixes. Lots of work on CI.
 
 Updated for version 3.20.4

 Memory leak fixes and C++11 features

@alyssais
Copy link
Member

@Xe can you retarget this to master please? It should be fixed there first, and then can be backported.

@alyssais
Copy link
Member

I sent an email to their mailing list imploring them to never do this again, but it’s a Google Group so I’m not confident my message will even be delivered.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 29, 2020
@Ma27 Ma27 merged commit cd388a5 into NixOS:release-20.03 Mar 29, 2020
@alyssais
Copy link
Member

alyssais commented Apr 1, 2020 via email

@alyssais
Copy link
Member

alyssais commented Apr 1, 2020 via email

@Ma27
Copy link
Member

Ma27 commented Apr 1, 2020

Thanks for the heads-up! Did a "forward-port" to master: 09b4747

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzizou bzizou Awaiting requested review from bzizou

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xe @alyssais @Ma27