libvorbis: document that patch for CVE-2017-14160 also fixes CVE-2018-10393. #82552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danderson
force-pushed
the
bug-57159-libvorbis
branch
from
16323d2
to
dde3b0f
Compare
adisbladis
requested changes
Mar 15, 2020
| @@ -12,6 +12,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| patches = [ | |||
| (fetchpatch { | |||
| # Also fixes CVE-2018-10393. | |||
There was a problem hiding this comment.
It's better to all CVEs in the patch name so it's detected by tools like vulnix and https://broken.sh.
There was a problem hiding this comment.
At the very least Vulnix only check the instantiated derivation, not the expression.
There was a problem hiding this comment.
Done, switched to the canonical "CVE...+CVE..." filename format.
There was a problem hiding this comment.
After this we need to switch the PR to staging though because the name change is a mass rebuild.
There was a problem hiding this comment.
After this we need to switch the PR to
stagingthough because the name change is a mass rebuild.
I've done this now.
…-10393. Fixes NixOS#57159. Signed-off-by: David Anderson <dave@natulte.net>
danderson
force-pushed
the
bug-57159-libvorbis
branch
from
dde3b0f
to
b5f9015
Compare
nh2
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57159
Motivation for this change
Helping tools figure out that CVE-2018-10393 is patched.
cc @andir as requested