Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micronaut: 1.3.2->1.3.4 #82626

Closed
wants to merge 1 commit into from
Closed

micronaut: 1.3.2->1.3.4 #82626

wants to merge 1 commit into from

Conversation

moaxcp
Copy link
Contributor

@moaxcp moaxcp commented Mar 15, 2020

Motivation for this change

Updated to newer version and fixed issue when run with java 11 on PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@moaxcp moaxcp changed the title micronaut: 1.3.2->1.3.3 micronaut: 1.3.2->1.3.4 May 1, 2020
@moaxcp
Copy link
Contributor Author

moaxcp commented May 1, 2020

I updated this to 1.3.4 instead of 1.3.3. I also added the correct dependencies the script uses.

@asbachb
Copy link
Contributor

asbachb commented Jun 17, 2020

1.3.6 released: https://github.com/micronaut-projects/micronaut-core/releases/tag/v1.3.6

asbachb
asbachb suggested changes Jun 20, 2020
View reviewed changes
pkgs/development/tools/micronaut/default.nix

stdenv.mkDerivation rec {
pname = "micronaut";
version = "1.3.2";
version = "1.3.4";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.3.4";
version = "1.3.6";

pkgs/development/tools/micronaut/default.nix

src = fetchzip {
url = "https://github.com/micronaut-projects/micronaut-core/releases/download/v${version}/${pname}-${version}.zip";
sha256 = "0jwvbymwaz4whw08n9scz6vk57sx7l3qddh4m5dlv2cxishwf7n3";
sha256 = "0mddr6jw7bl8k4iqfq3sfpxq8fffm2spi9xwdr4cskkw4qdgrrpz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "0mddr6jw7bl8k4iqfq3sfpxq8fffm2spi9xwdr4cskkw4qdgrrpz";
sha256 = "0jmj5xpj4invvpp289gh81vq7b4mmfhqb2h50yjn7wgdicyn295a";

@moaxcp moaxcp closed this Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbachb asbachb asbachb requested changes

@puzzlewolf puzzlewolf puzzlewolf requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moaxcp @asbachb @puzzlewolf @ryantm