Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.psutil: fix build on darwin #82524

Merged
merged 1 commit into from Mar 14, 2020
Merged

pythonPackages.psutil: fix build on darwin #82524

merged 1 commit into from Mar 14, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 14, 2020

Motivation for this change

Disable tests on darwin because it segfaults
See:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
pythonPackages.psutil: fix build on darwin
7e550c0 
Disable tests because it segfaults on darwin
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.psutil

@jonringer jonringer merged commit b860306 into NixOS:master Mar 14, 2020
@kfiz kfiz mentioned this pull request Apr 5, 2020
Closed
10 tasks
simonchatts added a commit to simonchatts/nixpkgs that referenced this pull request Jun 19, 2020
@simonchatts
pythonPackages.psutil: fix fix for darwin build
73f7453 
PR NixOS#82524 correctly diagnosed the problem, but slightly fluffed the boolean
logic (disable tests for Darwin as well as non-x86_64 arch).
@simonchatts simonchatts mentioned this pull request Jun 19, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jonringer