Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] nextcloud: 16.0.8 -> 16.0.9 #82697

Merged
merged 1 commit into from Mar 16, 2020
Merged

[19.09] nextcloud: 16.0.8 -> 16.0.9 #82697

merged 1 commit into from Mar 16, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 15, 2020 •
edited

Motivation for this change

https://nextcloud.com/security/advisory/?id=nC-SA-2020-015

I'm not sure if Nextcloud 16.0.9 already fixes this. Their advisory says it should be fixed by 16.0.10, but the advisory is dated from 2020-02-07, and 16.0.9 was released at 2020-03-13.

I also opened nextcloud/server#19976 upstream for clarification, we should probably still update to this version no matter if it fixes the issue or not.

TLDR: This was indeed a typo upstream. Adressed in nextcloud/security-advisories#21

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from tokudan March 15, 2020 23:35
@tokudan
Copy link
Contributor

tokudan commented Mar 15, 2020

@GrahamcOfBorg test nextcloud.basic nextcloud.with-postgresql-and-redis nextcloud.with-mysql-and-memcached

tokudan
tokudan approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@tokudan tokudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds for me and assuming the ofborg tests are fine, it sounds good to me

@ofborg ofborg bot requested review from fpletz, bachp, schneefux and globin March 15, 2020 23:43
@flokli flokli mentioned this pull request Mar 15, 2020
Merged
10 tasks
@flokli
nextcloud: 16.0.8 -> 16.0.9
311c3fd 
includes fix for nC-SA-2020-015.

See nextcloud/server#19976, the SA currently
has a typo - adressed in
nextcloud/security-advisories#21.
@ofborg ofborg bot requested a review from bachp March 16, 2020 21:41
@flokli flokli merged commit 8d7fd7e into NixOS:release-19.09 Mar 16, 2020
@flokli flokli deleted the 19.09-nextcloud-16.0.9 branch March 16, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokudan tokudan tokudan approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@schneefux schneefux Awaiting requested review from schneefux

@globin globin Awaiting requested review from globin

@bachp bachp Awaiting requested review from bachp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @tokudan @bachp