Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.51.0.92 -> 8.56.0.103 #82569

Merged
merged 1 commit into from Mar 14, 2020
Merged

skypeforlinux: 8.51.0.92 -> 8.56.0.103 #82569

merged 1 commit into from Mar 14, 2020

Conversation

emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Mar 14, 2020 •
edited

Motivation for this change

The motivation for this change is to update skypeforlinux to a recent version on 19.09 so that the upstream package is available. I simply cherry-picked what we already have on master.

cherry-picked 4665c94

Closes #81868

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from PanAeon and jraygauthier March 14, 2020 11:03
@FRidh
Copy link
Member

FRidh commented Mar 14, 2020

This should target release-19.09, not nixos-19.09.

@emmanuelrosa
Copy link
Contributor Author

Oh, damn.

I rebased the commit, but I don't think that's going to do the trick. I may have to abort and do a new PR.

@FRidh
Copy link
Member

FRidh commented Mar 14, 2020

Checkout release-19.09, cherry-pick the commit, and then force push to this branch.

@FRidh FRidh changed the base branch from nixos-19.09 to release-19.09 March 14, 2020 13:48
@FRidh
Copy link
Member

FRidh commented Mar 14, 2020

Actually, in this case it was sufficient to just change target branch in the top :)

@FRidh FRidh merged commit 68ad45f into NixOS:release-19.09 Mar 14, 2020
@emmanuelrosa emmanuelrosa deleted the skype-port-to-stable branch March 14, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanAeon PanAeon Awaiting requested review from PanAeon

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emmanuelrosa @FRidh @r-ryantm