Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc9: 9.2.0 -> 9.3.0 #82566

Merged
merged 1 commit into from Mar 15, 2020
Merged

gcc9: 9.2.0 -> 9.3.0 #82566

merged 1 commit into from Mar 15, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 14, 2020

Motivation for this change

https://gcc.gnu.org/gcc-9/changes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested review from fpletz and xbreak March 14, 2020 10:02
@Ma27 Ma27 requested a review from matthewbauer as a code owner March 14, 2020 10:02
@ofborg ofborg bot requested a review from Synthetica9 March 14, 2020 10:23
@FRidh FRidh added this to Needs review in Staging Mar 14, 2020
xbreak
xbreak approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@xbreak xbreak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested building gcc9 and a few random packages on CentOS 7 with sandbox enabled, and it all looks good.

Staging automation moved this from Needs review to Ready Mar 15, 2020
vcunat
vcunat approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested some packages. These bumps have been quite safe.

@vcunat vcunat merged commit c82d181 into NixOS:staging Mar 15, 2020
Staging automation moved this from Ready to Done Mar 15, 2020
@Ma27 Ma27 deleted the bump-gcc9 branch March 15, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@xbreak xbreak xbreak approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @vcunat @xbreak