Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Hydra build support for multiple devices #40

Closed
wants to merge 1 commit into from

Conversation

craigem
Copy link
Contributor

@craigem craigem commented Oct 26, 2019

This enables Hydra builds of mobile-nixos with the ability to select the devices that are being built.

@@ -0,0 +1,5 @@
{ devices ? [ "google-blueline" ] }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could default to "all devices"? Something like

builtins.filter (d: builtins.pathExists (./. + "/${d}/default.nix")) (builtins.attrNames (builtins.readDir ./.))


with import <nixpkgs> {};

lib.genAttrs devices ( device: (import ./. { inherit device; }).build.android-bootimg)
Copy link
Member

@samueldr samueldr Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achtung! Not all devices are android-based!

Though re-reading my system types, I see we need a couple well-known universal attributes. (This is on me to implement)

  • disk-image (already present in depthcharge) a full disk image with stage-2 and stage-1. Not applicable to all devices
  • stage-2, basically system.img for android-based devices. Most often not possible to cross-compile
  • stage-1, could be called initramfs or initrd, but those terms are confused and confusing.

This way, we could always try, by default, and build stage-1, stage-2 and disk-image on release, both as cross (on x86_64) or native (aarch64).

Any suggestions for better well-known attribute names? I'm thinking stage-1 and stage-2 without other qualifier could clash... Maybe something like stage-n.img?

@samueldr samueldr added the 4. type: enhancement New feature or request label Nov 19, 2019
@samueldr samueldr closed this in #97 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants