Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onionbalance: init at 0.2.0 #82638

Closed
wants to merge 3 commits into from
Closed

onionbalance: init at 0.2.0 #82638

wants to merge 3 commits into from

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Mar 15, 2020 •
edited

Motivation for this change

Add onionbalance to nixpkgs.

Requires a newer version of Tor that hasn't released as stable yet. See #86267.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

Looks like new Tor is in a month. https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases/043Status

@colemickens colemickens changed the title onionbalance: init at 0.1.9 onionbalance: init at 0.2.0 Apr 28, 2020
@colemickens colemickens mentioned this pull request Apr 28, 2020
Closed
10 tasks
@colemickens colemickens marked this pull request as ready for review May 16, 2020 10:59
@colemickens colemickens force-pushed the nixpkgs-onionbalance branch 3 times, most recently from c46c675 to 58c02c3 Compare May 18, 2020 10:07
@Kloenk
Copy link
Member

Kloenk commented Jun 15, 2020

I get a ModuleNotFoundError when running this. Never used onionbalance before, so I could be missing config, but I don't think so.

The error I get is:

Traceback (most recent call last):
  File "/nix/store/6sh0pn2ss0jqnjq4l5mzvrqfaj25ys6f-onionbalance-0.2.0/bin/.onionbalance-wrapped", line 6, in <module>
    from onionbalance.manager import main
  File "/nix/store/6sh0pn2ss0jqnjq4l5mzvrqfaj25ys6f-onionbalance-0.2.0/lib/python3.7/site-packages/onionbalance/manager.py", line 11, in <module>
    from setproctitle import setproctitle  # pylint: disable=no-name-in-module
ModuleNotFoundError: No module named 'setproctitle'

Kloenk
Kloenk reviewed Jun 15, 2020
View reviewed changes
pkgs/tools/security/onionbalance/default.nix Outdated
sha256 = "0v2rrc7y6blxvsxg04yqn81sjwymi09wwm7mdgmh53zc0ryh9zv6";
};

buildInputs = [ setuptools setproctitle stem future pyyaml cryptography pycrypto ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it to work with using propagatedBuildInputs instead of buildInputs

Suggested change
buildInputs = [ setuptools setproctitle stem future pyyaml cryptography pycrypto ];
buildInputs = [ setuptools ];
propagatedBuildInputs = [ setproctitle stem pyyaml cryptography pycrypto future ];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs setuptools in the propagatedBuildInputs. sorry for that

@Kloenk
Copy link
Member

Kloenk commented Jun 15, 2020 •
edited

I build a module for onionbalance, but did not get around to test it yet. Feel free to use the module in this pr, as it either way depends on this. Kloenk@35bfb9c

@Kloenk
Copy link
Member

Kloenk commented Jun 16, 2020

Had to rebase it and change some things, but now it Works. But I created a new branch for the rebase: Kloenk@36c23e4

@colemickens colemickens force-pushed the nixpkgs-onionbalance branch 3 times, most recently from b7659e9 to 68a088a Compare June 29, 2020 06:32
@colemickens colemickens force-pushed the nixpkgs-onionbalance branch 2 times, most recently from c5fd601 to a20969a Compare July 7, 2020 00:59
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@onny
Copy link
Contributor

onny commented Sep 7, 2022

Please rebase

@onny onny marked this pull request as draft September 7, 2022 06:51
@colemickens
Copy link
Member Author

I haven't thought about this in ages. Closing.

@colemickens colemickens deleted the nixpkgs-onionbalance branch October 2, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kloenk Kloenk Kloenk left review comments

@joachifm joachifm Awaiting requested review from joachifm

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colemickens @Kloenk @onny @ryantm