Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo: 0.67.0 -> 0.67.1 #82700

Merged
merged 1 commit into from Mar 16, 2020
Merged

hugo: 0.67.0 -> 0.67.1 #82700

merged 1 commit into from Mar 16, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Mar 16, 2020 •
edited

Motivation for this change

https://github.com/gohugoio/hugo/releases/tag/v0.67.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

JeffLabonte
JeffLabonte approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds on Linux with nixpkgsreview

@marsam marsam merged commit 30631f7 into NixOS:master Mar 16, 2020
@Frostman Frostman deleted the hugo-0.67.1 branch March 16, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLabonte JeffLabonte JeffLabonte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @JeffLabonte @marsam