Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce4-12: remove alias #82614

Merged
merged 1 commit into from Mar 15, 2020
Merged

xfce4-12: remove alias #82614

merged 1 commit into from Mar 15, 2020

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Mar 14, 2020

Motivation for this change

xfce4-12 should not point to xfce version 4.14. People will be better off seeing an error than unknowingly being force-switched to 4.12.

I think we should backport this change to 20.03 ASAP so it has time to sink before the release.

cc @worldofpeace @disassembler

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog Ekleog merged commit 7566b4f into NixOS:master Mar 15, 2020
@Ekleog
Copy link
Member Author

Ekleog commented Mar 15, 2020

Merged and backported as a4bf572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants