Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r-mvtnorm: add libiconv to buildInputs #82504

Merged
merged 1 commit into from May 11, 2020
Merged

r-mvtnorm: add libiconv to buildInputs #82504

merged 1 commit into from May 11, 2020

Conversation

mcwitt
Copy link
Contributor

@mcwitt mcwitt commented Mar 13, 2020 •
edited

Motivation for this change

Fixes build failure with ld: library not found for -liconv

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mcwitt
r-mvtnorm: add libiconv to buildInputs
dcda9df 
Fixes build failure with `ld: library not found for -liconv`
@mcwitt mcwitt requested a review from peti as a code owner March 13, 2020 17:48
@mcwitt
Copy link
Contributor Author

mcwitt commented May 11, 2020

@peti just wanted to put this on your radar again. I'm getting good use from this fix and it seems to me worth merging.

@peti peti merged commit ec5d1a7 into NixOS:master May 11, 2020
@mcwitt mcwitt deleted the fix/r-mvtnorm branch May 11, 2020 20:22
@mcwitt mcwitt mentioned this pull request May 15, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcwitt @peti @Janik-Haag