Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: introduce tests for interpreters #82560

Merged
merged 1 commit into from Mar 14, 2020
Merged

Python: introduce tests for interpreters #82560

merged 1 commit into from Mar 14, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Mar 14, 2020 •
edited

Motivation for this change

This adds tests to the passthru of all Python interpreters.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Python: introduce tests for interpreters
707c756 
This adds tests to the passthru of all Python interpreters.
@FRidh
Copy link
Member Author

FRidh commented Mar 14, 2020

@GrahamcOfBorg build python2.tests python3.tests pypy.tests pypy.tests python38.tests

@FRidh FRidh mentioned this pull request Mar 14, 2020
Merged
10 tasks
@FRidh

This comment has been minimized.

Sign in to view
@FRidh FRidh merged commit 13e7a3e into NixOS:master Mar 14, 2020
@FRidh FRidh deleted the tests branch March 14, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @adisbladis