Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskoin-core: remove from broken packages list #82563

Merged
merged 2 commits into from Mar 20, 2020
Merged

haskoin-core: remove from broken packages list #82563

merged 2 commits into from Mar 20, 2020

Conversation

jtobin
Copy link
Contributor

@jtobin jtobin commented Mar 14, 2020

Note that this PR includes e1408eb, which is also in #82562.

That commit unbreaks secp256k1-haskell, which in turn allows us to unbreak haskoin-core.

Motivation for this change

Unbreaks this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtobin
secp256k1-haskell: unbreak via override
e1408eb 
This library simply needs libsecp256k1 in its pkgconfig-depends.
@jtobin
haskoin-core: remove from broken packages list
9d7a16c 
e1408eb unbreaks secp256k1-haskell, which was the cause of this
package's failure to build.
@jtobin jtobin mentioned this pull request Mar 14, 2020
Merged
10 tasks
@alyssais
Copy link
Member

@GrahamcOfBorg build haskellPackages.haskoin-core

@peti peti merged this pull request into NixOS:haskell-updates Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtobin @alyssais @peti