Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.exts.pdo_odbc: init for all versions of php #82643

Merged
merged 2 commits into from Mar 15, 2020
Merged

phpPackages.exts.pdo_odbc: init for all versions of php #82643

merged 2 commits into from Mar 15, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 15, 2020

Motivation for this change

You mentioned that this module was missing, so here it comes :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [N/A] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from aanderse March 15, 2020 10:07
@etu
Copy link
Contributor Author

etu commented Mar 15, 2020

@GrahamcOfBorg build php74Packages.exts.pdo_odbc php73Packages.exts.pdo_odbc php72Packages.exts.pdo_odbc

@aanderse
Copy link
Member

Awesome! Thank you @etu 🎉 Did you get a chance to test?

@etu
Copy link
Contributor Author

etu commented Mar 15, 2020

@aanderse It builds and loads as an extension, so should be fine. But I haven't had a real database to connect it to.

@etu etu merged commit a0cb913 into NixOS:master Mar 15, 2020
@etu etu deleted the php-exts-pdo-odbc branch March 15, 2020 18:50
@aanderse
Copy link
Member

Thanks @etu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @aanderse