WIP: more rust #3416
Closed
WIP: more rust #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Mar 16, 2020
| @@ -0,0 +1,163 @@ | |||
| use crate::error::Error; | |||
There was a problem hiding this comment.
We don't need our own base64 implementation, since there is a crate for that.
There was a problem hiding this comment.
Likewise for base16 - we can use the hex crate.
| @@ -64,7 +65,7 @@ pub fn decode(input: &str) -> Result<Vec<u8>, crate::Error> { | |||
| let mut nr_bits_left: usize = 0; | |||
| let mut bits_left: u16 = 0; | |||
|
|
|||
| for c in input.chars().rev() { | |||
| for c in input.chars() { | |||
There was a problem hiding this comment.
Hm, is this correct? IIRC we really do need to process it in reverse order (our base32 encoding is pretty quirky).
|
I suppose we have to decide whether we really want to go forward with Rust. Currently we only use it for one small type ( |
|
Yeah I thought this would help me do the CAS stuff, but then C++ wasn't so bad so I'll just leave this as is. |
|
Closing if/until there is a big Rust push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've become a bit accelerationist about this. If we have some Rust, we might as well have all the Rust. Polyglot is bad.