Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentx: 2.2.1 -> 2.3.5, fix build #82622

Merged
merged 1 commit into from Mar 25, 2020
Merged

opentx: 2.2.1 -> 2.3.5, fix build #82622

merged 1 commit into from Mar 25, 2020

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Mar 14, 2020 •
edited

Motivation for this change

Updates opentx to the latest version. I switched to using gcc-arm-embedded instead of the Nix built cross-compiler because another part of the code wanted to use newlib_nano, and it could not be easily disabled. In general, I have found that Nix's arm-embedded platform is usually unusable because of issues like this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @elitak

@ofborg ofborg bot requested a review from elitak March 15, 2020 00:22
jonringer
jonringer approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
app opens fine

[3 built, 10 copied (539.3 MiB), 77.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82622
1 package built:
opentx

@elitak
Copy link
Contributor

elitak commented Mar 16, 2020

Built and ran for me. Seems good.

elitak
elitak approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@elitak elitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhipple bhipple merged commit fcbc415 into NixOS:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elitak elitak elitak approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @elitak @jonringer @bhipple