Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sshd: only include AuthorizedKeysCommand and AuthorizedKeysComm… #82621

Merged
merged 1 commit into from Mar 15, 2020
Merged

nixos/sshd: only include AuthorizedKeysCommand and AuthorizedKeysComm… #82621

merged 1 commit into from Mar 15, 2020

Conversation

aanderse
Copy link
Member

…andUser options if explicitly set

Motivation for this change

Fix for #82413

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis merged commit 58f2d11 into NixOS:master Mar 15, 2020
@aanderse aanderse deleted the ssh-fix branch March 15, 2020 00:26
@teto
Copy link
Member

teto commented Feb 8, 2023

I am thinking of removing these options: now that we have openssh.settings, we dont need nixpkgs support for it: the user can set services.openssh.settings.AuthorizedKeyCommand and the validation of the config will raise an alarm if the user forgot to set AuthorizedKeysCommandUser. What do you think ?

@aanderse
Copy link
Member Author

aanderse commented Feb 8, 2023

Yeah definitely. That sounds good. Thanks for all your work on the ssh module @teto.

@teto
Copy link
Member

teto commented Feb 9, 2023

cool. Done in #215397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @teto @adisbladis