Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmage: init at 1.4.42V6 #82655

Merged
merged 4 commits into from Mar 23, 2020
Merged

xmage: init at 1.4.42V6 #82655

merged 4 commits into from Mar 23, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Corona

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor Author

The server does not yet have a script to start.

@symphorien
Copy link
Member

The derivation lacks meta, and notably the license.

jonringer
jonringer reviewed Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM
opens fine

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82655
1 package built:
xmage

pkgs/games/xmage/default.nix
url = "https://github.com/magefree/mage/releases/download/xmage_1.4.42V6/xmage_${version}.zip";
sha256 = "14s4885ldi0rplqmab5m775plsqmmm0m89j402caiqm2q9mzvkhd";
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# since we are just fetching and wrapping, don't have remote jobs execute this
preferLocalBuild = true;

pkgs/games/xmage/default.nix
Comment on lines +32 to +34
description = "Magic Another Game Engine";
license = licenses.mit;
maintainers = with maintainers; [ matthiasbeyer ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add homepage please

@jonringer jonringer merged commit f24538c into NixOS:master Mar 23, 2020
@jonringer
Copy link
Contributor

squashed and committed

@matthiasbeyer matthiasbeyer deleted the add-xmage branch March 23, 2020 18:23
@catern
Copy link
Contributor

catern commented Aug 30, 2020

The xmage script added during the build doesn't work, because xmage tries to write to its installation directory (card images downloaded from the internet are stored alongside the installed plugins). I dug some into xmage but it seems it's fairly deeply hardcoded to write to the same directories it reads plugins from. I opened magefree/mage#7025 about this upstream.

@jonringer
Copy link
Contributor

Ideally they should have some logic like, "write_dir=${XDG_CACHE_HOME:-$HOME/.cache}/xmage"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiasbeyer @symphorien @jonringer @catern