New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wireshark: use relative cmake LIBDIR #82654
Conversation
Is there an upstream issue? (Because this is an upstream issue, since CMAKE_INSTALL_LIBDIR is allowed to be absolute.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a reference to upstream issue though (it is their bug).
That's unfortunate, since it's documented to allow absolute paths: "If the value is not already an absolute path, an absolute path is constructed typically by [...]." (https://cmake.org/cmake/help/v3.16/module/GNUInstallDirs.html). UPDATE: And there are CMAKE_INSTALL_FULL_<dir> variables for getting absolute paths, without having to manually prefix stuff like upstream apparently does unconditionally. |
`wireshark` expects `CMAKE_INSTALL_LIBDIR` to be relative and prefixes it with `CMAKE_INSTALL_PREFIX` in some places to make it absolute. This results in duplicate absolute paths being accessed, which don't exist. Making `CMAKE_INSTALL_LIBDIR` relative fixes this issue.
2e3d87f
to
35383b0
Compare
I opened an upstream issue and embedded the link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Motivation for this change
wireshark
expectsCMAKE_INSTALL_LIBDIR
to be relative and prefixesit with
CMAKE_INSTALL_PREFIX
in some places to make it absolute.This results in duplicate absolute paths being accessed, which don't exist like:
Therefore
extcap
binaries likesshdump
can't be used.Making
CMAKE_INSTALL_LIBDIR
relative fixes this issue.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)