New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mopidy: Create a mopidyPackages set #82651
Conversation
Interesting, I was doing the same for octoprint. Let's sync the approaches. |
I think creating a new scope with plugins is better than extending the Python packages set with plugins (like I did for octoprint). What is still needed however is a way to create a composition ( |
Thanks for the pull request! I cherry picked these two commits. This fixed the original issue I was complaining about in IRC (incompatible Python versions) but now I'm getting the following failure:
To reproduce:
For reference/completeness, here's my mopidy config:
|
as @gebner pointed out, the package set needs to be updated. I intend to merge this PR soon and leave it to the users (such as yourself) to update the plugins. |
@jluttine The It would be much better if someone who is actually using these plugins update them than if I do it since I don't know what to test. |
@FRidh Ok, so I shall not update those plugins now. I'll wait until this PR is merged and then open separate PRs for them. Is that what you meant? |
@adisbladis I tested Mopidy quickly with a minimal setup and it seems to work, thanks! Just for reference, here's my config:
I could then try to look into the extensions once this PR is merged. |
This is in anticipation of a mopidyPackages set
This is to avoid mixing python versions in the same plugin closure.
43211d7
to
5340ebe
Compare
Motivation for this change
Currently installing Mopidy plugin packages is using inconsistent python versions.
This may work just by chance in some cases but certainly not all.
This PR ensures a consistent
python
package is used across all Mopidy plugins.Note: I'm not a Mopidy user myself so it would be great if someone who is can test these changes. I'm merely acting on an issue reported in IRC in
#nixos
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @fpletz @jgillich @rvolosatovs @spwhitt @jluttine