Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faustCompressors: temp fix for build #82652

Closed
wants to merge 1 commit into from
Closed

faustCompressors: temp fix for build #82652

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Mar 15, 2020 •
edited

The new faust is more strict on it's code checking:
grame-cncm/faust#407

This commit temporarily hacks out some now broken code

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon
faustCompressors: temp fix for build
4c7f197 
The new faust is more strict on it's code checking:
grame-cncm/faust#407

This commit temporarily hacks out some now broken code
@magnetophon magnetophon mentioned this pull request Mar 15, 2020
Closed
10 tasks
@magnetophon magnetophon mentioned this pull request Jun 5, 2020
Draft
10 tasks
@orivej-nixos
Copy link
Contributor

Merged in #82650.

@magnetophon magnetophon deleted the faustCompressors branch August 20, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @orivej-nixos